fix: otp sent for report recipe#178
Open
captainPrime wants to merge 1 commit into
Open
Conversation
fokosun
requested changes
Aug 5, 2023
Contributor
|
Thanks @captainPrime I'll advice we make this a draft PR for the time being until the backend is ready. It will be ready this week so you can test again on your local. ty! |
fix: comments
captainPrime
force-pushed
the
fix-otp-issue-for-report
branch
from
3b45350 to
92a6504
Compare
Open
Contributor
|
@captainPrime is this ready for re review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - #169
Description
How Has This Been Tested?
I updated the reportit test file to ensure a request is made to the backend to get an otp , then tested that the form cant be sent without an otp entered
Checklist: